Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table lock flaky test #16429

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Sep 10, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

List lock revisions are returned in big-endian order, we need to sort them in ascending numeric order.

a4074603-bd1b-404e-bfc3-9a9617ff529b 2024-09-10T11:54:05.238526+08:00  WARN 
databend_query::locks::lock_manager: lock_manager.rs:135 list_lock_revisions reply: 
[(103, LockMeta { user: "root", node: "j3MoOFeUWV7kdHDgmWxxR2", query_id: "e67d5d9a-3e7f-466b-b923-2264077ce8ae", created_on: 2024-09-10T03:54:05.195603634Z, acquired_on: Some(2024-09-10T03:54:05.204791839Z), lock_type: TABLE, extra_info: {} }), 
(106, LockMeta { user: "root", node: "j3MoOFeUWV7kdHDgmWxxR2", query_id: "a4074603-bd1b-404e-bfc3-9a9617ff529b", created_on: 2024-09-10T03:54:05.228411910Z, acquired_on: None, lock_type: TABLE, extra_info: {} }), 
(97, LockMeta { user: "root", node: "j3MoOFeUWV7kdHDgmWxxR2", query_id: "81b42e53-23b2-44b6-b215-9c45bed02c6c", created_on: 2024-09-10T03:54:05.165842784Z, acquired_on: Some(2024-09-10T03:54:05.177124526Z), lock_type: TABLE, extra_info: {} }), 
(99, LockMeta { user: "root", node: "j3MoOFeUWV7kdHDgmWxxR2", query_id: "29fe86a8-e31a-4884-b098-01dec0625614", created_on: 2024-09-10T03:54:05.173372779Z, acquired_on: None, lock_type: TABLE, extra_info: {} })]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 10, 2024
@dosubot dosubot bot added A-query Area: databend query C-bug Category: something isn't working labels Sep 10, 2024
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dantengsky)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@zhyass zhyass added this pull request to the merge queue Sep 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 10, 2024
@drmingdrmer drmingdrmer merged commit fe83f31 into databendlabs:main Sep 10, 2024
113 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query C-bug Category: something isn't working lgtm This PR has been approved by a maintainer pr-bugfix this PR patches a bug in codebase size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants