Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore parser backrtace when map_res failed #16434

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: restore parser backrtace when map_res failed #16434

merged 3 commits into from
Sep 10, 2024

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Sep 10, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 10, 2024
@dosubot dosubot bot added A-query Area: databend query C-bug Category: something isn't working labels Sep 10, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 10, 2024
@andylokandy andylokandy added this pull request to the merge queue Sep 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 10, 2024
@andylokandy
fix: restore parser backrtace when map_res failed (#16434)
e78fd64 
* fix: restore parser backrtace when map_res failed

* fix

* fix
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 10, 2024
@BohuTANG BohuTANG merged commit 4bb036c into databendlabs:main Sep 10, 2024
78 checks passed
@andylokandy andylokandy deleted the dev9 branch September 11, 2024 04:38
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
A-query Area: databend query C-bug Category: something isn't working lgtm This PR has been approved by a maintainer pr-bugfix this PR patches a bug in codebase size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylokandy @sundy-li @BohuTANG