Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(executor): use event cause to refactor shuffle processor #16445

Merged
merged 4 commits into from
Sep 12, 2024
Merged

refactor(executor): use event cause to refactor shuffle processor #16445

merged 4 commits into from
Sep 12, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Sep 12, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(executor): use event cause to refactor shuffle processor

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 12, 2024
@zhang2014 zhang2014 requested a review from Dousir9 September 12, 2024 08:59
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 12, 2024
@dosubot dosubot bot added the A-executor Area: processor and shuffle label Sep 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@zhang2014 zhang2014 marked this pull request as draft September 12, 2024 09:20
@zhang2014 zhang2014 marked this pull request as ready for review September 12, 2024 14:49
@zhang2014 zhang2014 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into databendlabs:main with commit 8cff049 Sep 12, 2024
71 checks passed
@zhang2014 zhang2014 deleted the refactor/optimize_shuffle branch September 12, 2024 16:01
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

Assignees
No one assigned
Labels
A-executor Area: processor and shuffle lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhang2014 @Dousir9