-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enhancements of HTTP client session. #16452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
This PR changes 1000+ lines, ignoring generated files.
label
Sep 13, 2024
github-actions
bot
added
the
pr-refactor
this PR changes the code base without new features or bugfix
label
Sep 13, 2024
fix: refresh in memory state when /session/refresh 1. rename renew -> refresh. 2. extract HttpErrorCode. 3. adjust, extract and rename TTLs, add TTL_GRACE_PERIOD_QUERY
PR Summary
|
everpcpc
approved these changes
Sep 14, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query
Area: databend query
lgtm
This PR has been approved by a maintainer
pr-refactor
this PR changes the code base without new features or bugfix
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
2. . add
need_refresh
in session state, client do refresh only when it is true, client session id is written to meta only when there are temp tables (1. on /session/refresh 2. num of temp table changed from 0 to 1)./auth/verify
for gateway, instead of usingselect 1
need_sticky
in session state, set to true if in txn or there are temp tables, server return error if it is true but server changed/restarted.refresh_token
and for JWT session, no token is newedclient_session_id
of HTTPQuery to protect the query result.Tests
Type of change
This change is