-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): Procedure Part2 support arguments #16453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 24 files at r1, all commit messages.
Reviewable status: 12 of 24 files reviewed, 2 unresolved discussions (waiting on @TCeason)
src/meta/app/src/principal/procedure.rs
line 76 at r1 (raw file):
"Lanuage: {:?}, args {:?} return_type: {:?}, CreatedOn: {:?}, Script: {:?}, Comment: {:?}", self.procedure_language, self.arg_names,
use DisplaySliceExt::display_n::<1000>()
to build better for human output.
Other fields can also be benefitted from this method.
Suggestion:
"Lanuage: {:?}, args {} return_type: {:?}, CreatedOn: {:?}, Script: {:?}, Comment: {:?}",
self.procedure_language,
self.arg_names.display_n::<1000>(),
src/meta/app/src/principal/procedure_identity.rs
line 36 at r1 (raw file):
Self { name: name.to_string(), args: args.to_string().to_lowercase(),
Why is args
special and is converted to lower cases?
Why is args special and is converted to lower cases? No need to modify it. Already convert to lower in parse create/drop procedure. e.g. create procedure p1(x UInt8) -> should can be drop procedure p1(uint8) |
fd6808b
to
f8b2336
Compare
warit #16455 merged. |
tests/sqllogictests/suites/base/15_procedure/15_0002_procedure.test
Outdated
Show resolved
Hide resolved
635e171
to
6463b06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 24 files at r1, 1 of 3 files at r2, 3 of 4 files at r3, 7 of 9 files at r5, all commit messages.
Reviewable status: 24 of 28 files reviewed, 4 unresolved discussions (waiting on @andylokandy and @sundy-li)
docs cc @soyeric128 with @TCeason |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Parat II of #16348
this pr support call procedure();
After this pr, we need to add a new issue to enhanced procedure checks to make it more of a product than a prototype
fixes: Part of #14904
Tests
Type of change
This change is