Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor vacuum #16454

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 14, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: refactor vacuum

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 14, 2024
Copy link

what-the-diff bot commented Sep 14, 2024

PR Summary

  • Altered Behaviour for Duplicate Entries
    The UpsertTableCopiedFileReq has been updated in various places to replace fail_if_duplicated: true with insert_if_not_exists: true. This reflects a change in dealing with duplicate entries, with an emphasis on inserting new entries only when they don't already exist.

  • Formatted Output for the TableCopiedFileNameIdent Struct
    We've added a new implementation of the fmt::Display trait for the TableCopiedFileNameIdent struct. This will now enable a formatted output for its items improving readability and debuggability of code.

  • Field and Documentation Update in struct UpsertTableCopiedFileReq
    The UpsertTableCopiedFileReq struct has been modified to rename fail_if_duplicated field to insert_if_not_exists. Alongside the field name change, the corresponding documentation has been updated to clearly express that if true, existing keys will be ignored.

  • Consistent Renaming Across Files
    To maintain consistency with the new field name and its intended functionality, all files where UpsertTableCopiedFileReq is defined or implemented have undergone appropriate changes.

@drmingdrmer drmingdrmer force-pushed the 145-drop branch 2 times, most recently from c6ff253 to fb761f1 Compare September 18, 2024 03:46
@drmingdrmer drmingdrmer marked this pull request as ready for review September 18, 2024 04:14
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 18, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 18, 2024
@BohuTANG BohuTANG requested a review from SkyFan2002 September 18, 2024 05:48
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 18, 2024
@drmingdrmer drmingdrmer changed the title refactor: WIP: refactor vacuum refactor: refactor vacuum Sep 18, 2024
@drmingdrmer drmingdrmer merged commit c9e4f20 into databendlabs:main Sep 18, 2024
71 of 72 checks passed
@drmingdrmer drmingdrmer deleted the 145-drop branch September 18, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants