Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky test 09_0036_merge_into_without_dist #16457

Merged
merged 1 commit into from
Sep 14, 2024
Merged

fix: flaky test 09_0036_merge_into_without_dist #16457

merged 1 commit into from
Sep 14, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Sep 14, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix flaky test tests/sqllogictests/suites/base/09_fuse_engine/09_0036_merge_into_without_distributed_enable.test, by using different stage names for http/mysql handlers

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 14, 2024
@dantengsky dantengsky changed the title chore: fix flaky test 09_0036_merge_into_without_dist fix: flaky test 09_0036_merge_into_without_dist Sep 14, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 14, 2024
@dantengsky dantengsky marked this pull request as ready for review September 14, 2024 14:22
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 14, 2024
@dantengsky dantengsky requested a review from Dousir9 September 14, 2024 14:23
@dosubot dosubot bot added the A-storage Area: databend storage label Sep 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 14, 2024
@dantengsky dantengsky added this pull request to the merge queue Sep 14, 2024
Merged via the queue into databendlabs:main with commit 1a904c0 Sep 14, 2024
95 checks passed
@dantengsky dantengsky deleted the chore-fix-flaky-test branch September 14, 2024 14:57
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

Assignees
No one assigned
Labels
A-storage Area: databend storage lgtm This PR has been approved by a maintainer pr-bugfix this PR patches a bug in codebase pr-chore this PR only has small changes that no need to record, like coding styles. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky ci: 09_0036_merge_into_without_distributed_enable.test:627
2 participants
@dantengsky @Dousir9