-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Multi-thread recreate view/table gives error #16465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dantengsky and @sundy-li)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dantengsky and @sundy-li)
Nice shot! |
* fix: Multi-thread recreate view gives error * fix test
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
When executing
DROP TABLE IF EXISTS
, if the table metadata contains adrop_on
flag, indicating that the table has already been marked for deletion, no error will be returned. This ensures the operation is idempotent, preventing unnecessary errors from being raised if the table has already been dropped.Tests
Type of change
This change is