Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(executor): more edge detail for executing graph #16468

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Sep 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(executor): more edge detail for executing graph

before:

digraph {
    0 [ label = "system.one" ]
    1 [ label = "CompoundBlockOperator(Map)" ]
    2 [ label = "CompoundBlockOperator(Project)" ]
    3 [ label = "PullingExecutorSink" ]
    0 -> 1 [ ]
    1 -> 2 [ ]
    2 -> 3 [ ]
}

after

digraph {
    0 [ label = "system.one" ]
    1 [ label = "CompoundBlockOperator(Map)" ]
    2 [ label = "CompoundBlockOperator(Project)" ]
    3 [ label = "PullingExecutorSink" ]
    0 -> 1 [ 0 -> 0]
    1 -> 2 [ 0 -> 0]
    2 -> 3 [ 0 -> 0]
}

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - log

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 19, 2024
@zhang2014 zhang2014 requested a review from Dousir9 September 19, 2024 05:05
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 19, 2024
@dosubot dosubot bot added the A-executor Area: processor and shuffle label Sep 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2024
@zhang2014 zhang2014 enabled auto-merge September 19, 2024 05:15
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 19, 2024
@zhang2014 zhang2014 added this pull request to the merge queue Sep 19, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 19, 2024
@BohuTANG BohuTANG merged commit 31c2383 into databendlabs:main Sep 19, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: processor and shuffle lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants