chore: simplify SchemaApi::truncate_table() #16506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
dosubot
bot
added
the
size:L
dosubot
bot
added
the
pr-refactor
TCeason
approved these changes
Sep 24, 2024
|
truncate_table is lgtm |
drmingdrmer
force-pushed
the
159-list-tables
branch
2 times, most recently
from
7c0f68e to
f4d37ba
Compare
…-name - Change list_tables() to accept db_id instead of db_name for better precision - Modify return type from TableInfo to (table_name, table_id, SeqV<table_meta>). Because some info in TableInfo can not be provided by SchemaApi
truncate_table() first lists all copied files belonging to a table, then deletes them in small chunks. The delete operations assert that the seq of each file does not change. With this approach, there is no need to assert that the seq of the containing table does not change.
drmingdrmer
force-pushed
the
159-list-tables
branch
from
f4d37ba to
688f3a0
Compare
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
chore: simplify SchemaApi::truncate_table()
refactor: when SchemaApi::truncate_table(), no need to assert table seq
truncate_table() first lists all copied files belonging to a table,
then deletes them in small chunks. The delete operations assert that
the seq of each file does not change.
With this approach, there is no need to assert that the seq of the
containing table does not change.
refactor: SchemaApi::list_tables() should specify db-id instead of db-name
SeqV<table_meta>).
Because some info in TableInfo can not be provided by SchemaApi
Tests
Type of change
Related Issues
This change is