Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix planner cache cause modify async function does not take effect #16510

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Sep 24, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • The plan of search function, async function and udf contains some arguments defined in meta, which may be modified by user at any time. If the plan is cached, the modified arguments cannot take effect and a wrong result will be displayed. Therefore, sql containing these types of functions is made non-cacheable.
  • allow async function execute in where clause
  • fix async function as name could not be displayed
  • replace tantivy, tantivy-jieba, ethnum to datafuse-extras

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested a review from sundy-li September 24, 2024 10:26
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 24, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 24, 2024
@dosubot dosubot bot added A-planner Area: planner/optimizer C-bug Category: something isn't working labels Sep 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2024
@BohuTANG BohuTANG merged commit 110177e into databendlabs:main Sep 24, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-planner Area: planner/optimizer C-bug Category: something isn't working lgtm This PR has been approved by a maintainer pr-bugfix this PR patches a bug in codebase size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants