Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: http handler add X-DATABEND-VERSION in each response. #16518

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Sep 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

and some small refactors.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 25, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 25, 2024
@dosubot dosubot bot added the A-query Area: databend query label Sep 25, 2024
@youngsofun youngsofun requested a review from sundy-li September 25, 2024 08:28
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 26, 2024
@youngsofun youngsofun added this pull request to the merge queue Sep 27, 2024
Merged via the queue into databendlabs:main with commit 6473d8b Sep 27, 2024
81 checks passed
@youngsofun youngsofun deleted the http branch September 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-feature this PR introduces a new feature to the codebase size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants