refactor: Automatically chunk large key sets in KVPbApi methods #16561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
155-improve-failed-db
branch
4 times, most recently
from
f32f0fa to
418192b
Compare
zhyass
approved these changes
Oct 9, 2024
TCeason
approved these changes
Oct 9, 2024
- Modify KVPbApi::get_pb_vec() and KVPbApi::get_pb_values_vec() to automatically split large key sets into chunks of 256 keys - Simplifies caller logic by eliminating the need for manual key set splitting
drmingdrmer
force-pushed
the
155-improve-failed-db
branch
from
098cd10 to
c345f9e
Compare
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Automatically chunk large key sets in KVPbApi methods
Modify KVPbApi::get_pb_vec() and KVPbApi::get_pb_values_vec()
to automatically split large key sets into chunks of 256 keys
Simplifies caller logic by eliminating the need for manual key set splitting
Tests
Type of change
Related Issues
This change is