refactor: SchemaApi::get_table_meta_history() #16586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
159-get-table
branch
from
d8ef913 to
686391b
Compare
TCeason
reviewed
Oct 10, 2024
| let metas = get_table_meta_history(self, &now, table_id_list).await?; | ||
| history_ident: &TableIdHistoryIdent, | ||
| ) -> Result<Vec<(TableId, SeqV<TableMeta>)>, MetaError> { | ||
| let Some(seq_table_id_list) = self.get_pb(history_ident).await? else { |
There was a problem hiding this comment.
So this means : if a table under a db which contains 100 tables is invalid, list table from this db will return empty result?
cc @flaneur2020
I think it's better to print a warn or error log to point the err.
There was a problem hiding this comment.
my mistake。the method name should be get-retainable-x x x
There was a problem hiding this comment.
Fixed. Please review it again
It does not need to accept a `database-name` argument just for building an error. It does not need to return application level error: if a table is not found, just return an empty list. Rename SchemaApi::get_tables_history to list_retainable_tables; Rename SchemaApi::get_table_meta_history to get_retainable_tables; refactor: rename list_tables_history->list_gc_ready_tables;get_table_meta_history->get_gc_ready_tables;
drmingdrmer
force-pushed
the
159-get-table
branch
from
686391b to
b76a7ab
Compare
TCeason
approved these changes
Oct 10, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: SchemaApi::get_table_meta_history()
It does not need to accept a
database-nameargument just for buildingan error.
It does not need to return application level error: if a table is not
found, just return an empty list.
Tests
Type of change
Related Issues
This change is