Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disable prewhere for iceberg table for now #16597

Merged
merged 4 commits into from
Oct 11, 2024
Merged

fix: Disable prewhere for iceberg table for now #16597

merged 4 commits into from
Oct 11, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 11, 2024 •
edited
Loading

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Iceberg Engine doesn't support prewhere yet. Enabling prewhere in wrong will lead to read our schema has less fields than expected.

After this fix, we can run tpch now:

image

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Xuanwo added 4 commits October 11, 2024 13:23
@Xuanwo
chore: Print out schema of datablock and record batch
9207773 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
fix: add schema projection
bb2d423 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Revert "fix: add schema projection"
61283e3 
This reverts commit bb2d423.
@Xuanwo
Fix prewhere not supported by iceberg
8a3871a 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from BohuTANG and sundy-li October 11, 2024 08:55
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 11, 2024
@Xuanwo Xuanwo changed the title chore: Print out schema of datablock and record batch fix: Disable prewhere for iceberg table for now Oct 11, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 11, 2024
@Xuanwo Xuanwo removed the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 11, 2024
@Xuanwo Xuanwo enabled auto-merge October 11, 2024 09:14
@Xuanwo Xuanwo added this pull request to the merge queue Oct 11, 2024
Merged via the queue into databendlabs:main with commit 00b09ae Oct 11, 2024
83 checks passed
@Xuanwo Xuanwo deleted the fix-iceberg-schema branch October 11, 2024 10:13
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Databend Iceberg TPCH Q1 Failed for assertion left == right failed
2 participants
@Xuanwo @sundy-li