Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subquery returns wrong results under cluster #16606

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Oct 14, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 marked this pull request as draft October 14, 2024 03:49
@github-actions github-actions bot added pr-bugfix this PR patches a bug in codebase labels Oct 14, 2024
Copy link

what-the-diff bot commented Oct 14, 2024

PR Summary

  • Optimized the System to Remove Duplicates More Efficiently
    Reworked the existing logic to better handle and eliminate duplicate information when working with complex queries. This refactoring will make the product more reliable and efficient.

  • Enhanced Testing for Data Accuracy
    Introduced a new database test to make sure that duplicate data is effectively removed when we are dealing with sub-queries. This means that the product will be more trustworthy as we can be sure of its data handling capabilities.

  • Use of Temporary Data for Testing
    Created a temporary 'test_group' table and filled it with sample data. This is to facilitate the testing process and isn't something that will affect the final product.

  • Improved Checking of Data Aggregation Results
    Updated the system with a new query to cross-check results of data aggregation that involves subqueries. This ensures a high level of accuracy when handling duplicates, contributing to the overall fidelity of the service.

@xudong963 xudong963 force-pushed the fix_subquery_in_cluster branch from 25fa98b to 9e997ee Compare October 14, 2024 04:57
@xudong963 xudong963 marked this pull request as ready for review October 14, 2024 05:31
@xudong963 xudong963 requested a review from Dousir9 October 14, 2024 05:31
@Dousir9 Dousir9 enabled auto-merge October 14, 2024 06:32
@Dousir9 Dousir9 added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@xudong963 xudong963 added this pull request to the merge queue Oct 14, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 14, 2024
@BohuTANG BohuTANG merged commit 94f85db into databendlabs:main Oct 14, 2024
75 checks passed
@xudong963 xudong963 deleted the fix_subquery_in_cluster branch October 14, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the group function does not return the correct result
3 participants