Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve todo in dynamic sample #16629

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: resolve todo in dynamic sample #16629

merged 1 commit into from
Oct 21, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Oct 17, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 marked this pull request as draft October 17, 2024 03:40
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 17, 2024
@xudong963 xudong963 force-pushed the resolve_sample_to_do branch from fa535ce to 40de2d8 Compare October 18, 2024 02:07
@xudong963 xudong963 force-pushed the resolve_sample_to_do branch from 40de2d8 to e812c04 Compare October 21, 2024 06:56
@xudong963 xudong963 marked this pull request as ready for review October 21, 2024 07:43
@xudong963 xudong963 requested a review from Dousir9 October 21, 2024 07:43
@Dousir9 Dousir9 added this pull request to the merge queue Oct 21, 2024
Merged via the queue into databendlabs:main with commit fcf8e09 Oct 21, 2024
75 checks passed
@xudong963 xudong963 deleted the resolve_sample_to_do branch October 24, 2024 01:48
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xudong963 @Dousir9