Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): replace arrow2 with arrow-rs in serialize_column and deserialize_column #16655

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Oct 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This may be able to fix #16651

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 22, 2024
@sundy-li
Copy link
Member

This work may conflict with cc @andylokandy .

We can have this one. @andylokandy should convert BinaryView --> BinaryArray and use this function.

@sundy-li sundy-li requested a review from andylokandy October 22, 2024 04:00
@forsaken628 forsaken628 marked this pull request as ready for review October 22, 2024 08:17
@forsaken628 forsaken628 enabled auto-merge October 22, 2024 08:17
@forsaken628 forsaken628 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into databendlabs:main with commit 0dffb1e Oct 22, 2024
78 checks passed
@forsaken628 forsaken628 deleted the arrow_rs_ipc branch October 22, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: TPCDS Q67-Io error: LZ4 error: ERROR_blockChecksum_invalid.
3 participants