Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): sort spilling may hang #16672

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Oct 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fixes: #16668
TransformSortSpill does not handle finish correctly, causing upstream hang

Note: The bug reproduction conditions were quite harsh, and although there was reason to believe that the problem was there, the tests still didn't cover it accurately. It should be watched for a while longer.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 23, 2024
@forsaken628 forsaken628 changed the title fix(query): spill hang fix(query): sort spilling may hang Oct 23, 2024
@forsaken628 forsaken628 marked this pull request as ready for review October 24, 2024 08:34
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
@wubx
Copy link
Member

wubx commented Oct 25, 2024

I tested this work fine.

@forsaken628 forsaken628 enabled auto-merge October 25, 2024 07:42
@forsaken628 forsaken628 added this pull request to the merge queue Oct 25, 2024
Merged via the queue into databendlabs:main with commit 4a80ca2 Oct 25, 2024
72 checks passed
@forsaken628 forsaken628 deleted the fix-sort-hang branch October 25, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Internal. Code: 1001, Text = Pipeline graph is not finished
5 participants