-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): sort spilling may hang #16672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang2014
reviewed
Oct 23, 2024
src/query/service/src/pipelines/processors/transforms/transform_sort_spill.rs
Outdated
Show resolved
Hide resolved
forsaken628
force-pushed
the
fix-sort-hang
branch
from
October 23, 2024 10:28
f2d1101
to
bd28372
Compare
forsaken628
changed the title
fix(query): spill hang
fix(query): sort spilling may hang
Oct 23, 2024
forsaken628
force-pushed
the
fix-sort-hang
branch
from
October 24, 2024 09:29
35f0a6c
to
a7c7ce7
Compare
I tested this work fine. |
sundy-li
approved these changes
Oct 25, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fixes: #16668
TransformSortSpill
does not handle finish correctly, causing upstream hangNote: The bug reproduction conditions were quite harsh, and although there was reason to believe that the problem was there, the tests still didn't cover it accurately. It should be watched for a while longer.
Tests
Type of change
This change is