Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): use custom connector for udf client #16697

Merged
merged 12 commits into from
Oct 30, 2024

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Oct 28, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • enable SO_REUSEADDR for udf client
  • use global dns resolver

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 28, 2024
@everpcpc everpcpc marked this pull request as ready for review October 28, 2024 04:42
@everpcpc everpcpc requested review from sundy-li and Xuanwo October 28, 2024 04:42
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented, please don't merge.

@sundy-li
Copy link
Member

ok, please check that #16696 may also use this client construct function

@everpcpc
Copy link
Member Author

everpcpc commented Oct 28, 2024

As commented, please don't merge.

I thinks there's no need to block this PR.

  1. Hyper 0.14 is already pulled by FlightServiceClient with tonic 0.11, and this PR dose not introduce any new usage on it.
  2. After upgrading arrow-rs to 0.53 and tonic 0.12, hyper 0.14 would be gone eventually.
  3. DNS issue is a little urgent problem for udf client. If upgrading for arrow-rs has a long way to go, we can't wait for it.

cc @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Oct 28, 2024

  • After upgrading arrow-rs to 0.53 and tonic 0.12, hyper 0.14 would be gone eventually.

Yes, already working on this. This PR can be based on that PR instead.

PR will land in later one hour.

@Xuanwo
Copy link
Member

Xuanwo commented Oct 28, 2024

Hi, apologies for blocking you @everpcpc here, but the upcoming PR is quite large and has already taken me a full day. If possible, I'd really prefer for this PR to happen afterward.

@everpcpc everpcpc marked this pull request as draft October 29, 2024 14:52
@everpcpc everpcpc marked this pull request as ready for review October 30, 2024 00:48
@everpcpc everpcpc requested a review from Xuanwo October 30, 2024 00:48
@everpcpc
Copy link
Member Author

PTAL cc @Xuanwo

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @everpcpc for working on this!

@Xuanwo Xuanwo added this pull request to the merge queue Oct 30, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 30, 2024
@BohuTANG BohuTANG merged commit e3a3d70 into databendlabs:main Oct 30, 2024
75 checks passed
@everpcpc everpcpc deleted the feat-udf branch October 30, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants