fix(metrics): use f64::MAX as histogram bound to display +Inf properly #16701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
on rendering the prometheus metrics,
prometheus-client
checks the upper bound with f64::MAX, and renders it as+Inf
, which is a marker in calculatinghistogram_quantile
on monitoring.if
+Inf
is not displayed properly, it seems thathistogram_quantile
will return nothing.the source look likes this:
to display
+Inf
properly, we need let the upper bound withf64::MAX
.Tests
Type of change
This change is