Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplifying BlockMetaInfo Definitions #16716

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Oct 29, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The node local BlockMetaInfo definition has too much repetitive code, and the lack of explanatory information can be misleading.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 29, 2024
@forsaken628 forsaken628 requested a review from sundy-li October 29, 2024 05:38
@sundy-li sundy-li requested a review from zhang2014 October 29, 2024 07:15
@forsaken628 forsaken628 added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2024
@BohuTANG BohuTANG merged commit 3036fa8 into databendlabs:main Oct 30, 2024
75 checks passed
@forsaken628 forsaken628 deleted the local-meta branch October 30, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants