Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid returning error during computing binary comparison selectivity #16725

Merged
merged 1 commit into from
Oct 30, 2024
Merged

chore: avoid returning error during computing binary comparison selectivity #16725

merged 1 commit into from
Oct 30, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Oct 29, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 requested a review from sundy-li October 29, 2024 13:13
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 29, 2024
@xudong963 xudong963 requested a review from Dousir9 October 30, 2024 01:47
@Dousir9 Dousir9 added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@BohuTANG BohuTANG merged commit af37d28 into databendlabs:main Oct 30, 2024
75 checks passed
@xudong963 xudong963 deleted the fix_selectivity branch October 30, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xudong963 @Dousir9 @BohuTANG