Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTTP handler use cookie to pass session id to and from clients. #16735

Merged
merged 12 commits into from
Oct 31, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Oct 30, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • a part of HTTP handler and clients use cookie to share session id. #16720
  • add endpoint /v1/session/heartbeat, /v1/session/refresh now only used for refreshing session token
  • also use cookie to store last access time, thus can easily control the interval of refreshing server state.
  • rename need_refresh to need_keep_alive: client need to logout and heartbeat (if need to be idle for more than 4 hours) when it is true.
  • login support disable_session_token
  • fix logout to drop_client_session_state

after this pr, we can first add cookie support and logout to clients to make temp table availble

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun marked this pull request as draft October 30, 2024 18:18
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 30, 2024
@youngsofun youngsofun marked this pull request as ready for review October 30, 2024 19:06
@youngsofun youngsofun requested a review from sundy-li October 30, 2024 19:14
@youngsofun youngsofun added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@youngsofun youngsofun added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@youngsofun youngsofun added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@everpcpc everpcpc added this pull request to the merge queue Oct 31, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 31, 2024
@BohuTANG BohuTANG merged commit 41c4dbb into databendlabs:main Oct 31, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants