chore: refine vacuum #16743
Merged
chore: refine vacuum #16743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
dantengsky
force-pushed
the
chore-refine-vacuum
branch
from
25bde6a to
e71bd1a
Compare
11 tasks
If only orphans left, the vacuum should works as expected.
dantengsky
force-pushed
the
chore-refine-vacuum
branch
from
e71bd1a to
3f98be6
Compare
SkyFan2002
approved these changes
Nov 1, 2024
zhyass
approved these changes
Nov 1, 2024
dantengsky
added a commit
that referenced
this pull request
Nov 1, 2024
…6744) * chore: refine vacuum If only orphans left, the vacuum should works as expected. * try trigger CI * ignore RUSTSEC-2024-0376 temporarily * tweak ut case * tweak logic test * sync logic test `18_0011_alter_own_username` with main Avoid bendsql version issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
If only orphans left, the vacuum should continue working as expected (purge all the orphans).
Instead of using prefix extracted from the "path" of object belong to the GC root, using block/bloom_filter_index/segment prefix directly.
Tests
Type of change
This change is