Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clustering_information panic if string domain is none #16792

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Nov 7, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The cause of this panic is that the default domain maximum for String types is NULL. Therefore, wrapping the String type in a Nullable is necessary to handle this correctly.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 7, 2024
@zhyass zhyass requested a review from dantengsky November 7, 2024 16:14
@dantengsky
Copy link
Member

dantengsky commented Nov 8, 2024

@zhyass

LGTM, besides: seems you are using a different version of py code formatter black ?

@zhyass zhyass added this pull request to the merge queue Nov 8, 2024
Merged via the queue into databendlabs:main with commit 7e42582 Nov 8, 2024
74 checks passed
@zhyass zhyass deleted the feature_fix branch November 8, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: panic viewing clustering_information with a <8 character cluster key
3 participants