Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: align metrics field names with current behavior #16826

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Nov 13, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: align metrics field names with current behavior
  • Rename db_size to raft_log_size, which is the size of on-disk data
    of raft-log.
  • Rename key_num to snapshot_key_count.

This commit updates field names in

  • the the metrics API,
  • and the cluster status gRPC API.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@drmingdrmer drmingdrmer requested a review from everpcpc November 13, 2024 01:58
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 13, 2024
- Rename `db_size` to `raft_log_size`, which is the size of on-disk data
  of raft-log.
- Rename `key_num` to `snapshot_key_count`.

This commit updates field names in
- the the metrics API,
- and the cluster status gRPC API.
@drmingdrmer drmingdrmer marked this pull request as ready for review November 13, 2024 05:21
@drmingdrmer drmingdrmer merged commit 9af8ba3 into databendlabs:main Nov 13, 2024
77 checks passed
@drmingdrmer drmingdrmer deleted the 165-raft-log branch November 13, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants