Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refine the rule PushDownFilterWindowTopN in case top n is equal to 0. #16830

Merged
merged 4 commits into from
Nov 13, 2024
Merged

feat: refine the rule PushDownFilterWindowTopN in case top n is equal to 0. #16830

merged 4 commits into from
Nov 13, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Nov 13, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@forsaken628
top n 0
be77a5d 
Signed-off-by: coldWater <forsaken628@gmail.com>
@forsaken628
test
416c6ee 
Signed-off-by: coldWater <forsaken628@gmail.com>
@forsaken628
rename
4dc4a3a 
Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 13, 2024
@forsaken628 forsaken628 marked this pull request as ready for review November 13, 2024 06:04
@forsaken628 forsaken628 disabled auto-merge November 13, 2024 07:30
@forsaken628
fix
a6b9302 
Signed-off-by: coldWater <forsaken628@gmail.com>
@forsaken628 forsaken628 added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@BohuTANG BohuTANG merged commit 872627c into databendlabs:main Nov 13, 2024
74 checks passed
@forsaken628 forsaken628 deleted the top-n-window branch November 13, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

@xudong963 xudong963 xudong963 approved these changes

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@forsaken628 @sundy-li @xudong963 @Dousir9 @BohuTANG