Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): remove common/arrow crate #16846

Merged
merged 34 commits into from
Nov 19, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Nov 14, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. This pr removes common/arrow crate
  2. Migrate Buffer and Bitmap and common used column into a new crate named common/column
  3. Interact databend's column/data schema with arrow-rs array/data schema
  4. Introduce common_native for native storage_format which based on our own column

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 14, 2024
@sundy-li sundy-li marked this pull request as ready for review November 19, 2024 07:48
@sundy-li sundy-li added the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Nov 19, 2024
Cargo.toml Show resolved Hide resolved
@databendlabs databendlabs deleted a comment from github-actions bot Nov 19, 2024
@sundy-li sundy-li removed the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Nov 19, 2024
@sundy-li sundy-li added this pull request to the merge queue Nov 19, 2024
Merged via the queue into databendlabs:main with commit b40336b Nov 19, 2024
74 checks passed
@sundy-li sundy-li deleted the expression-column branch November 19, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants