Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): check storage request method with arg list-type #16849

Merged
merged 3 commits into from
Nov 15, 2024
Merged

fix(query): check storage request method with arg list-type #16849

merged 3 commits into from
Nov 15, 2024

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Nov 15, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 15, 2024
@everpcpc everpcpc requested a review from Xuanwo November 15, 2024 05:52
Xuanwo
Xuanwo approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@everpcpc everpcpc enabled auto-merge November 15, 2024 06:04
@everpcpc everpcpc added this pull request to the merge queue Nov 15, 2024
Merged via the queue into databendlabs:main with commit 2da2c8e Nov 15, 2024
74 checks passed
@everpcpc everpcpc deleted the fix-metrics branch November 15, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@everpcpc @Xuanwo