Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): remove SliceExt #16853

Merged
merged 3 commits into from
Nov 15, 2024
Merged

chore(query): remove SliceExt #16853

merged 3 commits into from
Nov 15, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Nov 15, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query): remove useless debug assert check wrapper in SliceExt

https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html#asserting-unsafe-preconditions

rust-lang/rust#120594

The Rust standard library has a number of assertions for the preconditions of unsafe functions, but historically they have only been enabled in #[cfg(debug_assertions)] builds of the standard library to avoid affecting release performance. However, since the standard library is usually compiled and distributed in release mode, most Rust developers weren't ever executing these checks at all.

Now, the condition for these assertions is delayed until code generation, so they will be checked depending on the user's own setting for debug assertions -- enabled by default in debug and test builds. This change helps users catch undefined behavior in their code, though the details of how much is checked are generally not stable.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from andylokandy November 15, 2024 06:47
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 15, 2024
@sundy-li sundy-li requested a review from zhang2014 November 15, 2024 06:47
@sundy-li sundy-li added this pull request to the merge queue Nov 15, 2024
Merged via the queue into databendlabs:main with commit 100bf47 Nov 15, 2024
74 checks passed
@sundy-li sundy-li deleted the slice-ext branch November 15, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants