Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove ValueRef and use Value instead #16891

Merged
merged 4 commits into from
Nov 26, 2024
Merged

refactor: remove ValueRef and use Value instead #16891

merged 4 commits into from
Nov 26, 2024

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Nov 20, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 20, 2024
@andylokandy andylokandy added this pull request to the merge queue Nov 26, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 26, 2024
@BohuTANG BohuTANG merged commit 6505b7a into databendlabs:main Nov 26, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylokandy @sundy-li @BohuTANG