chore: remove unused config_id from RaftConfig #16902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
drmingdrmer
force-pushed
the
173-refine-initialize
branch
from
43a3fec to
59fe798
Compare
Try initialize instead of check `is_open` flag. This flag may not be accurate: the raft storage is opend but no initialization is done yet. And remove trait `Opened` and refactor related struct names
`config_id` is used for separate sled-db key spaces for parallel tests. Since sled db is removed, this `config_id` is useless.
drmingdrmer
force-pushed
the
173-refine-initialize
branch
from
59fe798 to
86857d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
chore: remove unused config_id from RaftConfig
config_idis used for separate sled-db key spaces for parallel tests.Since sled db is removed, this
config_idis useless.chore: optimize meta-service initialization
Try initialize instead of check
is_openflag.This flag may not be accurate: the raft storage is opend but no
initialization is done yet.
And remove trait
Openedand refactor related struct namesTests
Type of change
Related Issues
This change is