Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable specifying copy options when create stage. #16925

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Nov 24, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Overview

copy options clauses are no longer allowed in create stage stmt

motivation

  1. (main) it is not clear and error prone to set copy options when create stage, which intended to serve as default value of copy related to this stage.
  2. it is a burden to maintain copy options in meta.
  3. it is bad to put both load and unload options in one struct.

Impact

  1. the only breaking change is that copy options clauses are no longer allowed in create stage stmt, I guess no one had ever use this.
  2. old stages with copy options can still be used as before, because the options does not take effect at all (covered by copy options from copy stmt, which is parsed with struct default values).

fixes: #(#16910)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added pr-feature this PR introduces a new feature to the codebase labels Nov 24, 2024
@youngsofun youngsofun force-pushed the copy_options branch 4 times, most recently from 91d5775 to 51291b7 Compare November 24, 2024 12:38
@youngsofun youngsofun added this pull request to the merge queue Nov 25, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 25, 2024
@BohuTANG
Copy link
Member

The summary is not cleary that what's changed in this PR?

@youngsofun
Copy link
Member Author

The summary is not cleary that what's changed in this PR?

updated

@youngsofun youngsofun requested a review from TCeason November 25, 2024 06:26
@youngsofun youngsofun added this pull request to the merge queue Nov 25, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 25, 2024
@BohuTANG BohuTANG merged commit 682039f into databendlabs:main Nov 25, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants