Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix flaky test #16945

Merged
merged 2 commits into from
Nov 26, 2024
Merged

ci: fix flaky test #16945

merged 2 commits into from
Nov 26, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Nov 26, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. fixes: flaky ci: cluster mode 09_0001_json_response #16935
  2. update result of statefull/stateless tests because the error format of BendSQL has changed

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun requested a review from TCeason November 26, 2024 07:58
@github-actions github-actions bot added the pr-build this PR changes build/testing/ci steps label Nov 26, 2024
Copy link
Contributor

At least one type of change must be checked in the PR description.
@youngsofun please update it 🙏.

1 similar comment
Copy link
Contributor

At least one type of change must be checked in the PR description.
@youngsofun please update it 🙏.

@youngsofun youngsofun changed the title ci: fix flaky test #16935 ci: fix flaky test Nov 26, 2024
@youngsofun youngsofun enabled auto-merge November 26, 2024 08:17
@youngsofun
Copy link
Member Author

youngsofun commented Nov 26, 2024

waiting for new release of bendsql with fix databendlabs/bendsql#512 cc @TCeason @sundy-li @everpcpc

@youngsofun youngsofun added this pull request to the merge queue Nov 26, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 26, 2024
@BohuTANG BohuTANG merged commit 4dd4290 into databendlabs:main Nov 26, 2024
72 checks passed
dantengsky pushed a commit to dantengsky/fuse-query that referenced this pull request Nov 26, 2024
* ci: fix flaky test databendlabs#16935

* ci: update error format of Bendsql.
Dousir9 added a commit to dantengsky/fuse-query that referenced this pull request Nov 27, 2024
Dousir9 added a commit to dantengsky/fuse-query that referenced this pull request Nov 27, 2024
dantengsky added a commit that referenced this pull request Nov 27, 2024
)

* feat: implement `is_not_null` selectivity based on null count in stats (#16730)

* feat: implement is_not_null selectivity based on null count in stats

* fix test

* chore(planner): improve cardinality estimation (#16938)

* chore(planner): improve cardinality estimation

* chore(planner): improve histogram cardinality estimation

* chore(planner): improve join cardinality

* chore(test): update sqllogictest

* chore(test): update sqllogictest

* chore(code): refine code

* chore(test): update sqllogictest

* chore(test): test ci tpch

* chore(code): fix typos

* chore(test): remove accurate_his test

* chore(test): fix sqllogictest

* chore(query): fix sub overflow

* chore(planner): refine scan histogram

* chore(test): update sqllogictest

* chore(test): update sqllogictest

* ci: fix flaky test  (#16945)

* ci: fix flaky test #16935

* ci: update error format of Bendsql.

* feat: filter null value before join (#16722)

* feat: filter null value before join

* fix lint

* add annotations and process possible crash

* dedup filters and fix tests (also need to fix native explain test)

* fix test

* support semi join

* fix test for semi join

* adjust threshold and enable only distribution

* chore(planner): resolve conflicts

* fix(query): support subquery in pivot (#16631)

* fix(query): support subquery in pivot

* add pivot and unpivot sqllogictests, fix unit-test

* code format

* chore(code): resolve conflicts

* chore(test): update sqllogictest

* chore(test): update sqllogictest

* Revert "ci: fix flaky test  (#16945)"

This reverts commit efcbac3.

* chore: add extra bracket for `and` and  `or` to make explain clear (#16494)

* fix: add extra bracket for and or

* add task test

* chore(test): update sqllogictest

* Revert "Revert "ci: fix flaky test  (#16945)""

This reverts commit 49ea151.

* fix(query): forbid explain explain statement (#16654)

fix(query): forbiden explain explain statement

* fix(ci): flaky test (#16933)

* flaky test

* fix

* fix test

* chore(code): resolve conflicts

* chore(test): update test

---------

Co-authored-by: xudong.w <wxd963996380@gmail.com>
Co-authored-by: Jk Xu <54522439+Dousir9@users.noreply.github.com>
Co-authored-by: Yang Xiufeng <yangxiufeng.c@gmail.com>
Co-authored-by: Liu Zhenlong <49094455+Dragonliu2018@users.noreply.github.com>
Co-authored-by: Dousir9 <736191200@qq.com>
Co-authored-by: TCeason <33082201+TCeason@users.noreply.github.com>
Co-authored-by: zhya <mytesla@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky ci: cluster mode 09_0001_json_response
4 participants