Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(planner): improve physical join #16962

Merged
merged 10 commits into from
Nov 30, 2024
Merged

chore(planner): improve physical join #16962

merged 10 commits into from
Nov 30, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Nov 28, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

If the output rows of build side is equal to 1, we use CROSS JOIN + FILTER instead of MERGE JOIN.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 28, 2024
@Dousir9 Dousir9 marked this pull request as ready for review November 28, 2024 11:27
@Dousir9 Dousir9 requested a review from xudong963 November 28, 2024 11:27
@xudong963 xudong963 added the ci-benchmark Benchmark: run all test label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-16962-a3e67b6-1732795083

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG merged commit 7f3ec69 into databendlabs:main Nov 30, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dousir9 @xudong963 @BohuTANG