Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): refine error message for stream read offset snapshot #16964

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Nov 28, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Refine error message for stream read offset snapshot.

mysql> select * from s;
ERROR 1105 (HY000): IllegalStream. Code: 2733, Text = Failed to read the offset snapshot: "1/95/_ss/3fa3378e5d5242579db5638d41b06b67_v4.mpk", maybe purged.
mysql> show full streams from default like 's';
+----------------------------+------+----------+---------+-----------+-------+---------+-------------+------------------------------------------------------------------------------------------------------+
| created_on                 | name | database | catalog | table_on  | owner | comment | mode        | invalid_reason                                                                                       |
+----------------------------+------+----------+---------+-----------+-------+---------+-------------+------------------------------------------------------------------------------------------------------+
| 2024-11-28 07:56:27.069466 | s    | default  | default | default.t | NULL  |         | append_only | Failed to read the offset snapshot: "1/95/_ss/3fa3378e5d5242579db5638d41b06b67_v4.mpk", maybe purged |
+----------------------------+------+----------+---------+-----------+-------+---------+-------------+------------------------------------------------------------------------------------------------------+
1 row in set (0.13 sec)
Read 1 rows, 301.00 B in 0.097 sec., 10.32 rows/sec., 3.03 KiB/sec.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 28, 2024
@zhyass zhyass requested review from Xuanwo and dantengsky November 28, 2024 10:21
@dantengsky dantengsky added this pull request to the merge queue Nov 28, 2024
Merged via the queue into databendlabs:main with commit 8cbda70 Nov 28, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants