Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlparser): fix order by followed by scalar #16967

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

chagelo
Copy link
Contributor

@chagelo chagelo commented Nov 28, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

close #16914

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 28, 2024
@chagelo chagelo marked this pull request as ready for review November 29, 2024 14:38
Signed-off-by: chagelo <changeto104@gmail.com>
Signed-off-by: chagelo <changeto104@gmail.com>
@chagelo chagelo force-pushed the fix-order-by-followed-by-scalar branch from 8f9ae2c to 1f1f6fd Compare November 29, 2024 14:39
@chagelo
Copy link
Contributor Author

chagelo commented Nov 29, 2024

I want to know about how we generally add logs, like that I want to use debug! to print rewrite_scalar here(just add a line debug!("rewrite_scalar: {:?}", rewirte_scalar);, but don't see any output in terminal or ./.databend, I'm gonna get farmilar with usage of crate log), or is there any other ways.

@b41sh
Copy link
Member

b41sh commented Dec 2, 2024

I want to know about how we generally add logs, like that I want to use debug! to print rewrite_scalar here(just add a line debug!("rewrite_scalar: {:?}", rewirte_scalar);, but don't see any output in terminal or ./.databend, I'm gonna get farmilar with usage of crate log), or is there any other ways.

The log is in this directory .databend/logs_1, for example: .databend/logs_1/databend-query-test_cluster.2024-12-02-11.0

Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chagelo LGTM, thanks for your contribution.

@b41sh b41sh added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@b41sh b41sh added this pull request to the merge queue Dec 2, 2024
Merged via the queue into databendlabs:main with commit 35c1c24 Dec 2, 2024
72 checks passed
@chagelo chagelo deleted the fix-order-by-followed-by-scalar branch December 2, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: order by literal with limit return error
3 participants