Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix segfault in list_domain #16979

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Dec 1, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 1, 2024
@forsaken628
Copy link
Collaborator Author

forsaken628 commented Dec 1, 2024

Here we found the bug and constructed the reproduce input using cargo-fuzz, which saves a lot of time compared to constructing the input by hand.

However, fuzz has some limitations. It consumes a lot of memory at compile time, so it should only be used for small core code that doesn't have too many dependencies.

@TCeason
Copy link
Collaborator

TCeason commented Dec 1, 2024

wait #16980

Signed-off-by: coldWater <forsaken628@gmail.com>
@sundy-li sundy-li enabled auto-merge December 2, 2024 03:38
@sundy-li sundy-li added this pull request to the merge queue Dec 2, 2024
Merged via the queue into databendlabs:main with commit 37de572 Dec 2, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: segfault in k_way_merge_sort_partition
3 participants