refactor: replace RangeMap with span-map for better range lookup
#17006
+636
−848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
179-refactor
branch
from
da06e0c to
bbb8fa0
Compare
drmingdrmer
changed the title
RangeMap with span-map for better range lookup
drmingdrmer
force-pushed
the
179-refactor
branch
2 times, most recently
from
e881033 to
a609111
Compare
Replace custom `RangeMap` implementation with `span-map` crate for more efficient range operations. `span-map` uses BTreeMap internally to store ranges, reducing boundary checks from O(n) to O(log n) when dealing with overlapping ranges. Also fixes single-key watch functionality that was previously broken.
drmingdrmer
force-pushed
the
179-refactor
branch
from
a609111 to
0e9df96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: replace
RangeMapwithspan-mapfor better range lookupReplace custom
RangeMapimplementation withspan-mapcrate for moreefficient range operations.
span-mapuses BTreeMap internally to storeranges, reducing boundary checks from O(n) to O(log n) when dealing
with overlapping ranges.
Also fixes single-key watch functionality that was previously broken.
Tests
Type of change
Related Issues
This change is