Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set path of cookie. #17008

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Dec 6, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

we used to assume client only care about name and value (ignore domain and path).
this fix is to avoid accumulation of cookies of diff paths if client enabled cookie mistakenly but not ignore path.
however, we can not set domain freely, because it will not work.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 6, 2024
@youngsofun youngsofun marked this pull request as draft December 6, 2024 03:05
@youngsofun youngsofun marked this pull request as ready for review December 6, 2024 04:03
@youngsofun
Copy link
Member Author

youngsofun commented Dec 6, 2024

@sundy-li

  1. add logic test code for this pr
  2. the cookie jar for python is simplified.

@youngsofun youngsofun added this pull request to the merge queue Dec 6, 2024
Merged via the queue into databendlabs:main with commit 2ede35d Dec 6, 2024
75 checks passed
@youngsofun youngsofun deleted the cookie branch December 6, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants