Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: auto split large mget_database_names_by_ids into chunks with KVPbApi::get_pb_values_vec() #17011

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Dec 6, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: auto split large mget_database_names_by_ids into chunks with KVPbApi::get_pb_values_vec()

And fix the issue that when db-meta is not found, the returned db-name
should be set to None too.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 6, 2024
@drmingdrmer drmingdrmer requested a review from TCeason December 6, 2024 10:07
@drmingdrmer drmingdrmer marked this pull request as ready for review December 6, 2024 10:07
@TCeason TCeason added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
…h `KVPbApi::get_pb_values_vec()`

And fix the issue that when db-meta is not found, the returned db-name
should be set to None too.
@drmingdrmer drmingdrmer merged commit 70c7768 into databendlabs:main Dec 7, 2024
72 of 73 checks passed
@drmingdrmer drmingdrmer deleted the 179-refactor branch December 7, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants