-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cluster): refactor cluster for dyn cluster [part 1] #17023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @BohuTANG and @zhang2014)
src/meta/types/tests/it/cluster.rs
line 57 at r1 (raw file):
assert_eq!( info, serde_json::from_slice::<NodeInfo>(&serde_json::to_vec(&info).unwrap()).unwrap()
This test should assert the serialized bytes does not contain cluster_id
or warehouse_id
, since the struct declared as:
#[serde(skip_serializing_if = "String::is_empty")]
pub cluster_id: String,
#[serde(skip_serializing_if = "String::is_empty")]
pub warehouse_id: String,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @BohuTANG)
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(cluster): refactor cluster for dyn cluster [part 1]
Tests
Type of change
This change is