Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(function): Decouple Function with DataField #5119

Closed
wants to merge 2 commits into from
Closed

improve(function): Decouple Function with DataField #5119

wants to merge 2 commits into from

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Apr 30, 2022

Signed-off-by: leiysky leiysky@outlook.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Decouple Function with DataField.

Changelog

  • Improvement

@leiysky
decouple Function with DataField
2dfd8ee 
Signed-off-by: leiysky <leiysky@outlook.com>
@leiysky leiysky requested a review from BohuTANG as a code owner April 30, 2022 15:39
@vercel
Copy link

vercel bot commented Apr 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 30, 2022 at 4:27PM (UTC)

@leiysky leiysky added the C-improvement Category: improvement label Apr 30, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 30, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@leiysky
fix clippy
8d0bed2 
Signed-off-by: leiysky <leiysky@outlook.com>
@leiysky
Copy link
Contributor Author

leiysky commented Apr 30, 2022

I've just found that ColumnRef::data_type returns physical type of the column. For Date or Timestamp we still need an extra logical type.

@leiysky leiysky closed this Apr 30, 2022
@leiysky leiysky mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
C-improvement Category: improvement need-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leiysky @databend-bot