Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(tests): add mini dataset to stateful test #6599

Closed
wants to merge 34 commits into from
Closed

ci(tests): add mini dataset to stateful test #6599

wants to merge 34 commits into from

Conversation

ZeaLoVe
Copy link
Contributor

@ZeaLoVe ZeaLoVe commented Jul 13, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add mini dataset to stateful test, include ontime and hits

Fixes #issue

@vercel
Copy link

vercel bot commented Jul 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 4:00AM (UTC)

@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jul 13, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Jul 13, 2022

IMHO, this test should be added as a separate github action because we can't run them locally.

@Xuanwo Xuanwo marked this pull request as draft July 13, 2022 06:37
@Xuanwo
Copy link
Member

Xuanwo commented Jul 13, 2022

I fixed the permission denied problem, hoping this will help you.

@Xuanwo Xuanwo mentioned this pull request Jul 14, 2022
Merged
@Xuanwo

This comment was marked as outdated.

Sign in to view
@Xuanwo
Copy link
Member

Xuanwo commented Jul 14, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

update

✅ Branch has been successfully updated

@Xuanwo
Copy link
Member

Xuanwo commented Jul 14, 2022

This PR is blocked by #6624

@Xuanwo
Copy link
Member

Xuanwo commented Jul 15, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

update

✅ Branch has been successfully updated

Xuanwo added 2 commits July 15, 2022 16:31
@Xuanwo
Fix value not wrapped correctly
143035b 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Make sure repo related envs exported
5e63ad0 
Signed-off-by: Xuanwo <github@xuanwo.io>
@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Jul 29, 2022 •
edited
Loading

cc @sundy-li seems hits.sql could not create table, I run it local with error.

WlJaM8tcjd

set enable_planner_v2 = 1; still error.

@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Jul 29, 2022

Continue after these PRs merged. #6880 #6899

@Xuanwo
Copy link
Member

Xuanwo commented Jul 30, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jul 30, 2022

update

✅ Branch has been successfully updated

@Xuanwo
Copy link
Member

Xuanwo commented Jul 31, 2022

Continue after these PRs merged. #6880 #6899

PTAL

@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Aug 1, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2022

update

✅ Branch has been successfully updated

@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Aug 1, 2022

Maybe split this pr is a good choice, one for ontime, the other for hits. Then we can track problem clearly. Now the hits always timeout , any idea? cc @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2022

Maybe split this pr is a good choice, one for ontime, the other for hits. Then we can track problem clearly. Now the hits always timeout , any idea? cc @Xuanwo

LGTM.

Let's merge the test case for ontime first.

This was referenced Aug 1, 2022
Merged
Closed
Merged
@ZeaLoVe
Copy link
Contributor Author

ZeaLoVe commented Aug 3, 2022

Already split into 2 pr, close here.

@ZeaLoVe ZeaLoVe closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

Assignees
No one assigned
Labels
pr-build this PR changes build/testing/ci steps pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeaLoVe @Xuanwo