Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planner): Fix order by column with invalid table name #6880

Merged
merged 15 commits into from
Jul 29, 2022

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jul 28, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

@vercel
Copy link

vercel bot commented Jul 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 29, 2022 at 10:13AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jul 28, 2022
@leiysky leiysky requested review from xudong963 and andylokandy July 28, 2022 12:17
@BohuTANG
Copy link
Member

sqllogic test failed :/

@BohuTANG
Copy link
Member

error: needlessly taken reference of both operands
  --> query/src/sql/planner/binder/sort.rs:90:36
   |
90 | ...                   && &ident.name == &item.column_name =>
   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D clippy::op-ref` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
help: use the values directly
   |
90 |                                 && ident.name == item.column_name =>
   |                                    ~~~~~~~~~~    ~~~~~~~~~~~~~~~~

error: needlessly taken reference of both operands
  --> query/src/sql/planner/binder/sort.rs:96:40
   |
96 | ...                   && &ident.name == &item.column_name =>
   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
help: use the values directly
   |
96 |                                     && ident.name == item.column_name =>
   |                                        ~~~~~~~~~~    ~~~~~~~~~~~~~~~~

@mergify mergify bot merged commit ee7b06b into databendlabs:main Jul 29, 2022
@leiysky leiysky deleted the fix-order-by branch July 29, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants