-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): fix binder create table #6899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
xudong963
reviewed
Jul 29, 2022
xudong963
reviewed
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parser-related golden test results need to update.
xudong963
approved these changes
Jul 29, 2022
leiysky
approved these changes
Jul 29, 2022
Following failed statements:
---------------------------------------------
Failed to execute. Collected info: 1105 (HY000): Code: 1005, displayText = error:
--> SQL:1:35
|
1 | create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
| ^^ expected `(`, `UNION`, `EXCEPT`, `INTERSECT`, or `SELECT`
.
Parsed Statement
at_line: 61,
s_type: Statement: ok, type: None,
suite_name: gen/02_function/02_0043_function_char,
text:
create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
results: [],
runs_on: {'mysql', 'clickhouse', 'http'},
---------------------------------------------
Expected: statement ok must get success response, not error code in response
Message:
Parsed Statement
at_line: 61,
s_type: Statement: ok, type: None,
suite_name: gen/02_function/02_0043_function_char,
text:
create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
results: [],
runs_on: {'mysql', 'clickhouse', 'http'},
---------------------------------------------
Failed to execute. Collected info: Orig exception: Code: 1005, displayText = error:
--> SQL:1:35
|
1 | create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
| ^^ expected `(`, `UNION`, `EXCEPT`, `INTERSECT`, or `SELECT`
.
Parsed Statement
at_line: 61,
s_type: Statement: ok, type: None,
suite_name: gen/02_function/02_0043_function_char,
text:
create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
results: [],
runs_on: {'mysql', 'clickhouse', 'http'}, |
@mergify update |
✅ Branch has been successfully updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
TEXT
,CHARACTER
tokenFixes #issue