Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): implement arithmetic functions for Date and Timestamp. #8202

Merged
merged 9 commits into from
Oct 16, 2022
Merged

feat(query): implement arithmetic functions for Date and Timestamp. #8202

merged 9 commits into from
Oct 16, 2022

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Oct 13, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Almost 3000 LOC are unit tests. Feel free to review the codes.

  • Remove IntervalType.

Implementation:

  • [add|substract]_[years|quarters|months|days|hours|minutes|seconds]
  • date_add/date_substract
  • arithmetic operator (+/-)

Unit tests:

  • [add|substract]_[years|quarters|months|days|hours|minutes|seconds]
  • date_add/date_substract
  • arithmetic operator (+/-)

Part of #8048

@vercel
Copy link

vercel bot commented Oct 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Oct 16, 2022 at 4:04AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Oct 13, 2022
@RinChanNOWWW RinChanNOWWW mentioned this pull request Oct 13, 2022
Closed
38 tasks
@RinChanNOWWW
Copy link
Contributor Author

RinChanNOWWW commented Oct 14, 2022 •
edited
Loading

Almost 3000 LOC are unit tests. Feel free to review the codes.

@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review October 14, 2022 12:12
@Xuanwo
Copy link
Member

Xuanwo commented Oct 14, 2022

Almost 3000 LOC are unit tests. Feel free to review the codes.

Safe! Very Safe!

@RinChanNOWWW RinChanNOWWW marked this pull request as draft October 16, 2022 03:10
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review October 16, 2022 03:10
@RinChanNOWWW
Copy link
Contributor Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2022

update

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@RinChanNOWWW needs to authorize modification on its head branch.
err-code: FFE03

@RinChanNOWWW
Copy link
Contributor Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2022

update

✅ Branch has been successfully updated

@mergify mergify bot merged commit 4014e6a into databendlabs:main Oct 16, 2022
@RinChanNOWWW RinChanNOWWW deleted the date_timestamp_arith branch October 16, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RinChanNOWWW @Xuanwo @b41sh @sundy-li