refactor(meta/sled): simplify SledTree APIs #8203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused API from `SledTree`, and merge APIs with similar functions, such as `range_keys()`, `range_values()` and `range_kvs()` and be replaced with a simple `range()`; `insert()` can be replaced with `append()`. Make `SledTree` APIs crate-public. Only leave key-space based API public.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-refactor
drmingdrmer
requested review from
lichuang and
ariesdevil
and removed request for
lichuang
BohuTANG
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
refactor(meta/sled): simplify SledTree APIs
Remove unused API from
SledTree, and merge APIs with similarfunctions, such as
range_keys(),range_values()andrange_kvs()and be replaced with a simple
range();insert()can be replaced withappend().Make
SledTreeAPIs crate-public. Only leave key-space based API public.Changelog
Related Issues