refactor(optimizer): use match to replace if else
#8291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-feature
xudong963
force-pushed
the
remove_predicate
branch
from
e3a9af0 to
f16d907
Compare
sundy-li
reviewed
Oct 18, 2022
src/query/service/src/sql/planner/optimizer/rule/rewrite/rule_eliminate_filter.rs
Outdated
Show resolved
Hide resolved
xudong963
force-pushed
the
remove_predicate
branch
from
f16d907 to
30c0cf2
Compare
|
Emm, after thinking, I realized However, @sundy-li 's suggestion is very good, so I will only change the code style in the ticket. |
xudong963
changed the title
match to replace if else
mergify
bot
added
the
pr-refactor
xudong963
force-pushed
the
remove_predicate
branch
from
83d288f to
6a83ee1
Compare
sundy-li
approved these changes
Oct 19, 2022
Xuanwo
reviewed
Oct 19, 2022
Xuanwo
approved these changes
Oct 19, 2022
Right I fount this issue too and have been fixed in 3e33b99 Thanks man! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Fixes #issue